Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set hostname when migrating ephemeral disks over TLS #4648

Merged
merged 3 commits into from
Sep 6, 2018
Merged

Set hostname when migrating ephemeral disks over TLS #4648

merged 3 commits into from
Sep 6, 2018

Commits on Sep 6, 2018

  1. client: set host name when migrating over tls 

    Not setting the host name led the Go HTTP client to expect a certificate
with a DNS-resolvable name. Since Nomad uses `${role}.${region}.nomad`
names ephemeral dir migrations were broken when TLS was enabled.

Added an e2e test to ensure this doesn't break again as it's very
difficult to test and the TLS configuration is very easy to get wrong.
    @schmichael
    schmichael committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    c55d166 View commit details
    Browse the repository at this point in the history

  2. fix race around error handling

    @schmichael
    schmichael committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    6b50475 View commit details
    Browse the repository at this point in the history

  3. Add changelog entry for #4648

    @schmichael
    schmichael committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    833dc7b View commit details
    Browse the repository at this point in the history