Fixed some issues with expose, port mapping, and environment variables #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Port mapping now works for reserved ports as well as dynamic ports - Environment variables were being set twice in two different ways; now they are only set once - Comprehensive tests for exposed ports, forwarded ports, and environment variables - Cleaned up / DRYed up a lot of test code
| containerPortInt := port.Value | ||
|
|
||
| // If the user has mapped a port using port_map we'll change it here | ||
| if len(driverConfig.PortMap) == 1 { |
There was a problem hiding this comment.
Does it makes sense to do > 0, and choose the first block?
There was a problem hiding this comment.
the first block is always 0. If we're worried about multiple port_map entries we should normalize this instead.
|
The test appears to be failing on docker client detection. I'm not sure how this is related to this change, though. |
cbednarski
added a commit
that referenced
this pull request
Nov 20, 2015
Fixed some issues with expose, port mapping, and environment variables
|
Fixes #507 |
benbuzbee
pushed a commit
to benbuzbee/nomad
that referenced
this pull request
Jul 21, 2022
* modify `TestRaft_RemoveFollower` to check removed node state * add test to verify that a removed node is not able to vote * do not transition to `Candidate` state if not part of stable configuration * add some comments to the tests * do not return if not transitioning state * add wait loop to test * remove test related to removed node voting * check `inConfig` instead of `hasVote` * updating warn log message to be more accurate
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[]map[string]inttomap[string]int