Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some issues with expose, port mapping, and environment variables #476

Merged
merged 4 commits into from
Nov 20, 2015
Merged

Fixed some issues with expose, port mapping, and environment variables #476

merged 4 commits into from
Nov 20, 2015

Commits on Nov 20, 2015

  1. Fixed some issues with expose, port mapping, and environment variables 

    - Port mapping now works for reserved ports as well as dynamic ports
- Environment variables were being set twice in two different ways; now they are only set once
- Comprehensive tests for exposed ports, forwarded ports, and environment variables
- Cleaned up / DRYed up a lot of test code
    @cbednarski
    cbednarski committed Nov 20, 2015
    Configuration menu
    Copy the full SHA
    f75404e View commit details
    Browse the repository at this point in the history

  2. Squash []map[string]type for port_map and labels into map[string]type

    @cbednarski
    cbednarski committed Nov 20, 2015
    Configuration menu
    Copy the full SHA
    63439ee View commit details
    Browse the repository at this point in the history

  3. Added nil to network.MapLabelToValues call

    @cbednarski
    cbednarski committed Nov 20, 2015
    Configuration menu
    Copy the full SHA
    e5d5d42 View commit details
    Browse the repository at this point in the history

  4. Added client checks back to the tests that can't use dockerSetup()

    @cbednarski
    cbednarski committed Nov 20, 2015
    Configuration menu
    Copy the full SHA
    c298425 View commit details
    Browse the repository at this point in the history