Disable AWS and GCE fingerprinting via environment variables #488
Conversation
|
Can you explain why you want this behavior? |
|
I think a service sould call any 3rd party service only when it really have to. The decision if the calls will be made should be left by the operator. |
|
Fair enough, if you'd like to implement this behavior can you please do it similar to #473. It should be disabled through the config not environment variables. |
|
Allright, I added the option |
| @@ -451,10 +451,30 @@ func (c *Client) setupNode() error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (c *Client) compileOptionsList(key string) (map[string]struct{}, bool) { | |||
There was a problem hiding this comment.
Can we remove this method. Doesn't look like it is being used?
|
I pushed the desired code changes and switched to a whitelist. However, travis fails but I can't see why. |
|
Nice! Thanks @max0d41 |
Disable AWS and GCE fingerprinting via environment variables
Adds metrics suggested in hashicorp#488, to record the percentage of time the main and FSM goroutines are busy with work vs available to accept new work, to give operators an idea of how close they are to hitting capacity limits.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
When setting
AWS_ENV_URLorGCE_ENV_URLtodisabledfingerprinting of this services is completely disabled.Additionally, what do you think about moving this two variables to the config file?