Client Config allows a driver whitelist. #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| c.logger.Printf("[DEBUG] client: available drivers %v", avail) | ||
|
|
||
| if len(whitelisted) != 0 { | ||
| c.logger.Printf("[DEBUG] client: drivers disabled by whitelist: %v", whitelisted) |
There was a problem hiding this comment.
This message makes it seem like whitelisted are disabled. If these are actually the disabled drivers whitelisted should be named skipped or similar, and the message made a bit more clear e.g. "these drivers were skipped" or better just indicate which ones were actually loaded. E.g.
"client: discovered drivers %v"
"client: loaded drivers %v from whitelist
dadgar
added a commit
that referenced
this pull request
Nov 20, 2015
Client Config allows a driver whitelist.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client Config allows a driver whitelist to disable unwanted drivers. This closes #467