-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nomad Job Logs Should Support Widescreen Format #5303
Comments
@cpumanaz @dantoml This looks like a good first-time contribution issue. I would like to tackle this, can I start working on this? Also, I have a few questions
|
Are there any current rules that could be applied for a buffer? That the log window could have a minimum size which is the current size and will expand as the window gets larger than what is required for the minimum size. Size: 0 –> X (current size). |
Hey @jacekjagiello, I'm personally not too familiar with the Nomad UI codebase, @DingoEatingFuzz should be able to provide some pointers here though. |
Hi @jacekjagiello, this is a great idea and I'd love a contribution here.
Views intentionally have a max-width set to avoid a lot of horizontal eye-scanning (especially with tables and the like that normally fit just fine within 1200px). I think the log view is an exception to this rule.
I think we can avoid a media-query here by just making that particular page wider. I imagine it would look something like adding an Thank you for digging into this! |
@DingoEatingFuzz Thanks, I'll do PR within a few days |
@jacekjagiello How are things going with the wide-screen format? |
@cpumanaz PR is open |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
If you have a question, prepend your issue with
[question]
or preferably use the nomad mailing list.If filing a bug please include the following:
Nomad version
Nomad v0.8.7 (21a2d93+CHANGES)
Operating system and Environment details
Windows 10
Google Chrome
Issue
Logs (stdout,stderr) should be expandable or expand out to the right edge of browser windows. Most monitors in the last 10 years have been sold in a wide-screen format, and Nomad should not wrap logs unnecessarily.
Feature Request: Please allow for an adjustable or wider log output pane to prevent scrolling of logs and wasted space. Please see the attached image as an example of wasted space.
Reproduction steps
Open Nomad task Logs on a wide-screen monitor, observe wasted space.
The text was updated successfully, but these errors were encountered: