Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs view - support widescreen format #5400

Conversation

jacekjagiello
Copy link

Fixes #5303

Added simple class that allows section to take whole available space

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 6, 2019

CLA assistant check
All committers have signed the CLA.

@DingoEatingFuzz
Copy link
Contributor

Huzzah! Thanks for jumping on this. I checked out your branch and can confirm that it does what it reports to do:

image

I'm happy merging this as is, but since we're in the middle of beta-testing 0.9 I want to consult with the team first. If it doesn't make it into 0.9 it will surely make it into 0.9.1.

@jacekjagiello
Copy link
Author

jacekjagiello commented Mar 7, 2019

I'm happy merging this as is, but since we're in the middle of beta-testing 0.9 I want to consult with the team first. If it doesn't make it into 0.9 it will surely make it into 0.9.1.

That's great, @cpumanaz FYI

@DingoEatingFuzz
Copy link
Contributor

@jacekjagiello, since we haven't released an 0.9 release candidate, it looks like this one is gonna barely slip into 0.9!

Merging now, great work!

@DingoEatingFuzz DingoEatingFuzz merged commit 3fedff6 into hashicorp:master Mar 7, 2019
@jacekjagiello
Copy link
Author

@DingoEatingFuzz Thanks for merging this. I'm happy that I can give a little help with making such great software even better. I'll be looking forward to contributing in the future 😀

@cpumanaz
Copy link

Thank you for your work @jacekjagiello

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nomad Job Logs Should Support Widescreen Format
4 participants