Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect: enable setting tags on consul connect sidecar service in job… #6448

Merged
merged 1 commit into from
Oct 17, 2019
Merged

connect: enable setting tags on consul connect sidecar service in job… #6448

merged 1 commit into from
Oct 17, 2019

Conversation

shoenig
Copy link
Member

@shoenig shoenig commented Oct 8, 2019

…spec (#6415)

nickethier
nickethier approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@nickethier nickethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@preetapan preetapan added this to the 0.10.1 milestone Oct 16, 2019
@schmichael schmichael self-requested a review October 16, 2019 18:39
schmichael
schmichael approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update Equals method and LGTM

@shoenig shoenig merged commit 8c7a7b6 into master Oct 17, 2019
@shoenig shoenig deleted the f-set-connect-sidecar-tags branch October 17, 2019 20:14
@notnoop notnoop mentioned this pull request Oct 24, 2019
Closed
@pashinin pashinin mentioned this pull request Nov 10, 2019
Closed
@tgross tgross mentioned this pull request Nov 22, 2019
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmichael schmichael schmichael approved these changes

@nickethier nickethier nickethier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shoenig @schmichael @nickethier @preetapan