Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Configure json logging in the docker plugin section. #6563

Closed
powellchristoph opened this issue Oct 25, 2019 · 4 comments · Fixed by #10156
Closed

Feature Request: Configure json logging in the docker plugin section. #6563

powellchristoph opened this issue Oct 25, 2019 · 4 comments · Fixed by #10156

Comments

@powellchristoph
Copy link

powellchristoph commented Oct 25, 2019

Currently Nomad overwrites the docker daemon logging configuration to json-file with log rotation (max-file=2 and max-size=2m and that can be changed within the job's config.

I would like to be able to set the json-file configuration options within the docker plugin section on my clients and have it applied to all docker jobs.

@apollo13
Copy link
Contributor

Agreed, this would be very useful. @tgross is this something you'd be okay with adding? Ie basically move the defaults into the plugin config, so the user can override it. Or would dropping the default logging config and using whatever dockerd has configured also be an option?

@tgross
Copy link
Member

tgross commented Mar 10, 2021

Agreed, this would be very useful. @tgross is this something you'd be okay with adding? Ie basically move the defaults into the plugin config, so the user can override it. Or would dropping the default logging config and using whatever dockerd has configured also be an option?

It seems reasonable on its face; I just took a quick look at where we set those values in drivers/docker/driver.go and it looks like we could have it use the current values as the default, let the plugin config set the values, and let the job override those values. Mostly a matter of getting the HCL schema plumbing for the plugin.

That being said, we're not likely to get to this anytime in the immediate future. I'd be happy to review a PR that takes it on though!

apollo13 added a commit to apollo13/nomad that referenced this issue Mar 10, 2021
hashicorp#6563

For backwards-compat, defaults to the previous defaults.
@apollo13
Copy link
Contributor

I'd be happy to review a PR that takes it on though!

Thanks @tgross, there is #10156 awaiting your review :D

@tgross tgross self-assigned this Mar 10, 2021
@tgross tgross added this to Needs Triage in Nomad - Community Issues Triage via automation Mar 10, 2021
@tgross tgross moved this from Needs Triage to In Progress in Nomad - Community Issues Triage Mar 10, 2021
apollo13 added a commit to apollo13/nomad that referenced this issue Mar 10, 2021
hashicorp#6563

For backwards-compat, defaults to the previous defaults.
apollo13 added a commit to apollo13/nomad that referenced this issue Mar 10, 2021
hashicorp#6563

For backwards-compat, defaults to the previous defaults.
Nomad - Community Issues Triage automation moved this from In Progress to Done Mar 12, 2021
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants