Connect Proxy Kind is not interpolated #6853
Assignees
Labels
Milestone
Comments
schmichael
added
type/bug
theme/client
theme/consul/connect
schmichael
added a commit
that referenced
this issue
Dec 12, 2019
Fixes #6853 Canonicalize jobs first before adding any sidecars. This fixes a bug where sidecar tasks were added without interpolated names and broke validation. Sidecar tasks must be canonicalized independently. Also adds a group network to the mock connect job because it wasn't a valid connect job before!
schmichael
added a commit
that referenced
this issue
Dec 13, 2019
Fixes #6853 Canonicalize jobs first before adding any sidecars. This fixes a bug where sidecar tasks were added without interpolated names and broke validation. Sidecar tasks must be canonicalized independently. Also adds a group network to the mock connect job because it wasn't a valid connect job before!
schmichael
added a commit
that referenced
this issue
Dec 13, 2019
Fixes #6853 Canonicalize jobs first before adding any sidecars. This fixes a bug where sidecar tasks were added without interpolated names and broke validation. Sidecar tasks must be canonicalized independently. Also adds a group network to the mock connect job because it wasn't a valid connect job before!
shoenig
added a commit
that referenced
this issue
Dec 9, 2020
This PR enables job submitters to use interpolation in the connect block of jobs making use of consul connect. Before, only the name of the connect service would be interpolated, and only for a few select identifiers related to the job itself (#6853). Now, all connect fields can be interpolated using the full spectrum of runtime parameters. Note that the service name is interpolated at job-submission time, and cannot make use of values known only at runtime. Fixes #7221
shoenig
added a commit
that referenced
this issue
Dec 9, 2020
This PR enables job submitters to use interpolation in the connect block of jobs making use of consul connect. Before, only the name of the connect service would be interpolated, and only for a few select identifiers related to the job itself (#6853). Now, all connect fields can be interpolated using the full spectrum of runtime parameters. Note that the service name is interpolated at job-submission time, and cannot make use of values known only at runtime. Fixes #7221
shoenig
added a commit
that referenced
this issue
Dec 9, 2020
This PR enables job submitters to use interpolation in the connect block of jobs making use of consul connect. Before, only the name of the connect service would be interpolated, and only for a few select identifiers related to the job itself (#6853). Now, all connect fields can be interpolated using the full spectrum of runtime parameters. Note that the service name is interpolated at job-submission time, and cannot make use of values known only at runtime. Fixes #7221
shoenig
added a commit
that referenced
this issue
Dec 9, 2020
This PR enables job submitters to use interpolation in the connect block of jobs making use of consul connect. Before, only the name of the connect service would be interpolated, and only for a few select identifiers related to the job itself (#6853). Now, all connect fields can be interpolated using the full spectrum of runtime parameters. Note that the service name is interpolated at job-submission time, and cannot make use of values known only at runtime. Fixes #7221
shoenig
added a commit
that referenced
this issue
Dec 9, 2020
This PR enables job submitters to use interpolation in the connect block of jobs making use of consul connect. Before, only the name of the connect service would be interpolated, and only for a few select identifiers related to the job itself (#6853). Now, all connect fields can be interpolated using the full spectrum of runtime parameters. Note that the service name is interpolated at job-submission time, and cannot make use of values known only at runtime. Fixes #7221
|
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Nomad version
0.10.2
Issue
When validating jobs on submission the service names are interpolated but the task kind is not.
This means if a service names uses an interpolated value such as
${JOB}a Connect-enabled job will fail to validate with the error:Augmenting the error message with details makes the difference of interpolation obvious:
Job file (if appropriate)
Just add
${JOB}to the service name in the example Connec job: https://gist.github.com/schmichael/c22e696d6dca0ed585d98ab7a7e2fe63The text was updated successfully, but these errors were encountered: