-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update gopsutil #6957
Comments
@shishir-a412ed wrote in #6720 (comment):
We were waiting for a release from You're right that we don't currently use go modules, but we plan on getting there. We've run into some complications with nested modules and our In the meanwhile, we use govendor for managing dependencies. |
@tgross I tried to vendor $$ govendor fetch github.com/shirou/gopsutil@v2.20.1 It is updating a bunch of files, however it doesn't update the file which has the fix (
|
Just checked and https://github.com/shirou/gopsutil/blob/v2.20.1/host/host_linux.go does have the fix, that's strange. The govendor docs say:
So I'm wondering if you want to use the syntax for the specific tag, rather than the "latest" (maybe there's something weird about the way it detects latest that isn't playing nice with the library's go mod setup.) Something worth checking is to run |
@tgross I am getting the following error when I try:
Any idea what's going wrong? Can you give it a try? Just to make sure it's not a problem with my environment. |
Here is my (probably incomplete) understandings. The version of docker links to an old x/sys/windows The recent gopsutils 2.19.12+, shirou/gopsutil@a61c905, needs a fresher version of x/sys/windows. Going anywhere above 2.19.6 requires to bump docker, in order to be able to bump x/sys/windows and use gopsutils 2.20.2+ Been there, done that, #5807 -- didn't go through |
Closed by #7350 |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
The panic described in #6954 was caused by a missing length check in
gopsutil
which we've contributed upstream as shirou/gopsutil#822. Once that's been merged and released, we should updategopsutil
The text was updated successfully, but these errors were encountered: