volumes: add task environment interpolation to volume_mount #7364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
f-csi-volume-hook-interpolation
branch
from
5fbdc82
to
cb50d12
Compare
tgross
added a commit
that referenced
this pull request
Mar 22, 2020
tgross
added a commit
that referenced
this pull request
Mar 22, 2020
tgross
added a commit
that referenced
this pull request
Mar 22, 2020
tgross
added a commit
that referenced
this pull request
Mar 23, 2020
tgross
added a commit
that referenced
this pull request
Mar 23, 2020
tgross
added a commit
that referenced
this pull request
Mar 23, 2020
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7362. This will also help enable e2e tests (#7361) as it makes it easier to identify the writes for a specific task's use of a volume.
Because the volume hook is shared between host volumes and CSI volumes, this effectively adds interpolation to host volumes as well. I'll add that to the changelog for 0.11.0. (We could probably also add this to the
volumestanza but I want to keep the changeset minimal and scope this to a problem I actually have. 😀)