csi: fix filesystem write paths in e2e tests #7361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
b-csi-e2e-inputs
branch
from
76d1bc1
to
f7779d3
Compare
|
Removing you from review @langmartin until I've got the mount paths issue fixed. |
tgross
force-pushed
the
b-csi-e2e-inputs
branch
from
f7779d3
to
a19e172
Compare
tgross
force-pushed
the
b-csi-e2e-inputs
branch
from
a19e172
to
1bc808b
Compare
The writer jobs for the CSI e2e tests will write to locations in the alloc dir and not arbitrary locations at the root. This changeset mounts the CSI volume at a location within the alloc dir, uses the alloc ID as a better-namespaced identifier of the file we write, and corrects the shell used by the busybox container.
tgross
force-pushed
the
b-csi-e2e-inputs
branch
from
1bc808b
to
9ebeecb
Compare
|
I've added a note about #7365 where we can improve this, but this should now fix the problem described here. |
tgross
added a commit
that referenced
this pull request
Mar 22, 2020
The writer jobs for the CSI e2e tests will write to locations in the alloc dir and not arbitrary locations at the root. This changeset mounts the CSI volume at a location within the alloc dir, uses the alloc ID as a better-namespaced identifier of the file we write, and corrects the shell used by the busybox container.
tgross
added a commit
that referenced
this pull request
Mar 22, 2020
The writer jobs for the CSI e2e tests will write to locations in the alloc dir and not arbitrary locations at the root. This changeset mounts the CSI volume at a location within the alloc dir, uses the alloc ID as a better-namespaced identifier of the file we write, and corrects the shell used by the busybox container.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a few bugs in the e2e test suite for CSI following testing of #7356.
The writer jobs for the CSI e2e tests will write to locations in the alloc dir and not arbitrary locations at the root. This changeset mounts the CSI volume at a location within the alloc dir, uses the alloc ID as a better-namespaced identifier of the file we write, and corrects the shell used by the busybox container.
This PR doesn't quite bring us to a working state; we'll need to fix #7338, #7360, and #7362 at least.