Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: fix rendering of task name emoji in exec terminal command-editing #7459

Closed
backspace opened this issue Mar 24, 2020 · 1 comment · Fixed by #7813
Closed

UI: fix rendering of task name emoji in exec terminal command-editing #7459

backspace opened this issue Mar 24, 2020 · 1 comment · Fixed by #7813
Assignees
@backspace
Labels
theme/ui type/bug

Comments

@backspace
Copy link
Contributor

image
@backspace backspace added this to the 0.11.0 milestone Mar 24, 2020
@backspace backspace self-assigned this Mar 24, 2020
@backspace backspace mentioned this issue Mar 24, 2020
Merged
@schmichael schmichael removed this from the 0.11.0 milestone Apr 9, 2020
backspace added a commit that referenced this issue Apr 27, 2020
@backspace
Add workaround to exclude emoji from task escaping
001decd 
This closes #7459.
backspace added a commit that referenced this issue Apr 27, 2020
@backspace
Add workaround to exclude emoji from task escaping
1fba252 
This closes #7459.
backspace added a commit that referenced this issue Apr 27, 2020
@backspace
Add workaround to exclude emoji from task escaping
e9abc5a 
This closes #7459.
@backspace backspace mentioned this issue Apr 27, 2020
Merged
backspace added a commit that referenced this issue Feb 3, 2021
@backspace
Add workaround to exclude emoji from task escaping
01746ed 
This closes #7459.
backspace added a commit that referenced this issue Feb 8, 2021
@backspace
Fix exec escaping for emoji task name
c3e55c1 
This closes #7459.

While emoji don’t actually need escaping, expanding the
expression that enumerates all task name characters that
don’t need escaping to include emoji is prohibitive, since
it’s a discontinuous range. The emoji-regex project has
such an expression and it’s 12kB.

This fixes the regular expression to property escape emoji
as a single character instead of as its component bytes.
Thanks to @DingoEatingFuzz for the suggestion.
backspace added a commit that referenced this issue Feb 9, 2021
@backspace
Fix exec escaping for emoji task name (#7813)
24b9a89 
This closes #7459.

While emoji don’t actually need escaping, expanding the
expression that enumerates all task name characters that
don’t need escaping to include emoji is prohibitive, since
it’s a discontinuous range. The emoji-regex project has
such an expression and it’s 12kB.

This fixes the regular expression to property escape emoji
as a single character instead of as its component bytes.
Thanks to @DingoEatingFuzz for the suggestion.
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@backspace backspace

Labels
theme/ui type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UI: Add workaround to exclude emoji from task escaping hashicorp/nomad
2 participants
@backspace @schmichael