CNI Implementation #7518
Merged
CNI Implementation #7518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoenig
approved these changes
May 5, 2020
There was a problem hiding this comment.
This looks great @nickethier ! Mostly just nits and random thoughts.
Was ReloadableFingerprint supposed to be implemented by CNIFingerprint ?
nickethier
force-pushed
the
f-cni
branch
2 times, most recently
from
7611b30
to
c1b914b
Compare
Signed-off-by: Nick Ethier <nethier@hashicorp.com>
ignore comparing networking for now in test Apply suggestions from code review Co-authored-by: Seth Hoenig <shoenig@hashicorp.com>
nickethier
added a commit
that referenced
this pull request
Jun 16, 2020
schmichael
pushed a commit
that referenced
this pull request
Jun 18, 2020
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how networks are fingerprinted, adds cni fingerprinting and generalizes how CNI configuration is applied.
Fingerprinting
Previously, when a fingerprinter returned a network or networks, they overwrote and previous results. This PR changes this to merge results and adds the Mode field to all node network resources to differentiate traditional or "host" networks from detected "cni" networks.
These are later used to check network feasibility in the scheduler