Change consul SI tokens to be local #8068
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoenig
previously approved these changes
May 28, 2020
schmichael
requested changes
Jun 30, 2020
There was a problem hiding this comment.
Just noting this should not be merged. This PR is blocked by changes in Consul upstream. See #8063 for details.
We either have to wait to merge this PR until all of our users are on a fixed version of Consul, or we have to fingerprint Consul versions and only create local tokens for compatible versions of Consul.
|
|
shoenig
force-pushed
the
f-local-si-token
branch
from
5acc4c2
to
b1bca7b
Compare
This PR updates the changelog, adds notes the 1.3 upgrade guide, and updates the connect integration docs with documentation about the new requirement on Consul ACL policies of Consul agent default anonymous ACL tokens.
shoenig
force-pushed
the
f-local-si-token
branch
from
1179c09
to
ef95e7d
Compare
|
Closed by #12586 |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes generated consul SI tokens to be local instead of global.
Fixes #8063