Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect: create SI tokens in local scope #12586

Merged
merged 3 commits into from
Apr 19, 2022
Merged

connect: create SI tokens in local scope #12586

merged 3 commits into from
Apr 19, 2022

Conversation

shoenig
Copy link
Member

@shoenig shoenig commented Apr 15, 2022 •
edited

  • Change consul SI tokens to be local
  • docs: update documentation with connect acls changes

Closes #8063 #8068

jorgemarey and others added 2 commits April 18, 2022 08:22
@jorgemarey @shoenig
Change consul SI tokens to be local
7bfb482
@shoenig
docs: update documentation with connect acls changes
b2a2f77 
This PR updates the changelog, adds notes the 1.3 upgrade guide, and
updates the connect integration docs with documentation about the new
requirement on Consul ACL policies of Consul agent default anonymous ACL
tokens.
@shoenig shoenig marked this pull request as ready for review April 18, 2022 17:54
schmichael
schmichael approved these changes Apr 18, 2022
View reviewed changes
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work!

.changelog/8068.txt Outdated
```

```release-note:breaking-change
The minimum Consul version supported by Nomad's Connect integration is now Consul v1.8.0.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a connect: prefix here? I don't think so but just checking.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah we do, good catch!

@schmichael
Copy link
Member

Make sure to link/close any related Github issues too.

@shoenig shoenig merged commit 3e394fc into main Apr 19, 2022
@shoenig shoenig deleted the f-local-si-token branch April 19, 2022 12:53
@shoenig shoenig mentioned this pull request Apr 19, 2022
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmichael schmichael schmichael approved these changes

@jrasell jrasell Awaiting requested review from jrasell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[question] Change consul SI tokens to be local?
3 participants
@shoenig @schmichael @jorgemarey