Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic port range should be configurable in client config #8186

Closed
evandam opened this issue Jun 17, 2020 · 6 comments
Closed

Dynamic port range should be configurable in client config #8186

evandam opened this issue Jun 17, 2020 · 6 comments
Labels
help-wanted We encourage community PRs for these issues! stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/config theme/networking type/enhancement

Comments

@evandam
Copy link

evandam commented Jun 17, 2020

Similar to #7399 and #1087, it would be helpful to set the range Nomad uses for dynamic ports, but on the client level instead of the job/task.

I see there's reserved_ports that can be set, but that still relies on the hard-coded range of 20k-32k. For example, there's no way to shift the dynamic port range from 20000-32000 to 32000-44000.

I'm also unsure if #3072 would still pose an issue with setting large reserved_port ranges.

prestonp added a commit to prestonp/nomad that referenced this issue Jul 21, 2020
The intent of this change is to support shifting the range used for assigning dynamic ports (hashicorp#8186).

This makes the static dynamic port range configurable per new client settings `dynamic_port_range_min` and `dynamic_port_range_max`.
prestonp added a commit to prestonp/nomad that referenced this issue Aug 5, 2020
The intent of this change is to support shifting the range used for assigning dynamic ports (hashicorp#8186).

This makes the static dynamic port range configurable per new client settings `dynamic_port_range_min` and `dynamic_port_range_max`.
prestonp added a commit to prestonp/nomad that referenced this issue Aug 5, 2020
The intent of this change is to support shifting the range used for assigning dynamic ports (hashicorp#8186).

This makes the static dynamic port range configurable per new client settings `dynamic_port_range_min` and `dynamic_port_range_max`.
@tgross tgross added the stage/accepted Confirmed, and intend to work on. No timeline committment though. label Aug 28, 2020
@tgross
Copy link
Member

tgross commented Aug 28, 2020

This looks like a reasonable request and one we've wanted to do for a while. There's an open PR in #8478 from @prestonp that is a good first attempt. If that gets fixed up I think we'll be good to get this in.

prestonp added a commit to prestonp/nomad that referenced this issue Sep 10, 2020
The intent of this change is to support shifting the range used for assigning dynamic ports (hashicorp#8186).

This makes the static dynamic port range configurable per new client settings `dynamic_port_range_min` and `dynamic_port_range_max`.Fix port range to server config
prestonp added a commit to prestonp/nomad that referenced this issue Sep 10, 2020
The intent of this change is to support shifting the range used for assigning dynamic ports (hashicorp#8186).

This makes the static dynamic port range configurable per new server settings `dynamic_port_range_min` and `dynamic_port_range_max`.
@tgross tgross added this to Needs Roadmapping in Nomad - Community Issues Triage Feb 12, 2021
@tgross tgross removed this from Needs Roadmapping in Nomad - Community Issues Triage Mar 4, 2021
@insanitybit
Copy link

insanitybit commented Aug 9, 2021

I think ideally I would be able to do this task-level. I'd like to set up some iptables and monitoring that can rely on specific port ranges being allocated to specific tasks.

@a-zagaevskiy
Copy link
Contributor

I've already had a working code, initially based on the mentioned PR #8478, which takes into account recommendations about spreading client's dynamic port range via fingerprints. And it works quite well. But it fixes Nomad v0.10.6. I could try to rebase it on the current master, if you are interested.

@Oloremo
Copy link
Contributor

Oloremo commented Sep 30, 2021

Waiting for that feature as well

benbuzbee pushed a commit to benbuzbee/nomad that referenced this issue Oct 6, 2021
The intent of this change is to support shifting the range used for assigning dynamic ports (hashicorp#8186).

This makes the static dynamic port range configurable per new server settings `dynamic_port_range_min` and `dynamic_port_range_max`.
@jrasell
Copy link
Member

jrasell commented Oct 28, 2021

This functionality was added within #11167 and will be released in Nomad 1.2.0.

@jrasell jrasell closed this as completed Oct 28, 2021
@Amier3 Amier3 added the help-wanted We encourage community PRs for these issues! label Apr 1, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help-wanted We encourage community PRs for these issues! stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/config theme/networking type/enhancement
Projects
None yet
Development

No branches or pull requests

7 participants