UI: Add a key to the alloc table on the task group detail page #8216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding keys tells Ember to rerender matching entries instead of destroying and recreating. Without this key, every time the allocation collection changes, every allocation row gets destroyed and recreated. This happens a lot, since each allocation needs to be reloaded which dirties the collection. Since allocation rows fetch stats on init, each of these many many renders results in a stats request. By using key and rerendering matching records, this all goes away. Since the rows aren't being destroyed and recreated, the init stats request isn't being made overnumerously.
DingoEatingFuzz
changed the title
Ember Asset Size actionAs of 6dfca71 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
backspace
approved these changes
Jun 19, 2020
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding keys tells Ember to rerender matching entries instead of destroying and recreating.
Without this key, every time the allocation collection changes, every allocation row gets destroyed and recreated.
This happens a lot, since each allocation needs to be reloaded which dirties the collection.
Since allocation rows fetch stats on init, each of these many many renders results in a stats request.
By using a key and rerendering matching records, this all goes away. Since the rows aren't being destroyed and recreated, the init stats request isn't being made overnumerously.
Before and after screenshots of a page with five running allocations and a list of 10+ total allocations.
Before: 181 stats requests, 10 of which are from steady-state polling.
After: 15 stats requests, 10 of which are from steady-state polling.
