Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Add a key to the alloc table on the task group detail page #8216

Merged
merged 1 commit into from
Jun 19, 2020
Merged

UI: Add a key to the alloc table on the task group detail page #8216

merged 1 commit into from
Jun 19, 2020

Commits on Jun 19, 2020

  1. Add a key to the alloc table on the task group detail page 

    Adding keys tells Ember to rerender matching entries instead of
destroying and recreating.

Without this key, every time the allocation collection changes, every
allocation row gets destroyed and recreated.

This happens a lot, since each allocation needs to be reloaded which
dirties the collection.

Since allocation rows fetch stats on init, each of these many many
renders results in a stats request.

By using key and rerendering matching records, this all goes away. Since
the rows aren't being destroyed and recreated, the init stats request
isn't being made overnumerously.
    @DingoEatingFuzz
    DingoEatingFuzz committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    6dfca71 View commit details
    Browse the repository at this point in the history