Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infer connect native task name when possible #8274

Closed
shoenig opened this issue Jun 24, 2020 · 1 comment · Fixed by #8392
Closed

Infer connect native task name when possible #8274

shoenig opened this issue Jun 24, 2020 · 1 comment · Fixed by #8392
Assignees
@shoenig
Labels
theme/consul/connect Consul Connect integration type/enhancement

Comments

@shoenig
Copy link
Member

shoenig commented Jun 24, 2020

Currently when defining a Connect Native service, it is always required to configure the service.task parameter so that Nomad knows which Nomad Task is implementing the Consul Connect Native service. If there is only one task in the Task Group along with the Native enabled Service Definition, we can simply infer that Task name. If the service.task parameter is set and there is only one task, the normal job endpoint validation rules already do the right thing.
@shoenig shoenig added type/enhancement theme/consul/connect Consul Connect integration labels Jun 24, 2020
@shoenig shoenig self-assigned this Jun 24, 2020
shoenig added a commit that referenced this issue Jul 8, 2020
@shoenig
consul/connect: infer task name in service if possible
44df264 
Before, the service definition for a Connect Native service would always
require setting the `service.task` parameter. Now, that parameter is
automatically inferred when there is only one task in the task group.

Fixes #8274
@shoenig shoenig mentioned this issue Jul 8, 2020
Merged
@github-actions
Copy link

github-actions bot commented Nov 5, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shoenig shoenig

Labels
theme/consul/connect Consul Connect integration type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

consul/connect: infer task name for native service if possible hashicorp/nomad
1 participant
@shoenig