-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource stanza completed ignored during first plan #8544
Comments
Hi @shantanugadgil, thanks for raising this with the reproduction steps. Running this locally I managed to find that the regression occurred as part of the 0.11.0 release. In the 0.10.5 release the plan warns as expected (shown below).
|
Fixes #8544 This PR fixes a bug where using `nomad job plan ...` always report no change if the submitted job contain scaling. The issue has three contributing factors: 1. The plan endpoint doesn't populate the required scaling policy ID; unlike the job register endpoint 2. The plan endpoint suppresses errors on job insertion - the job insertion fails here, because the scaling policy is missing the required ID 3. The scheduler reports no update necessary when the relevant job isn't in store (because the insertion failed) This PR fixes the first two factors. Changing the scheduler to be more strict might make sense, but may violate some idempotency invariant or make the scheduler more brittle.
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Nomad version
Nomad v0.12.1 (14a6893)
Operating system and Environment details
CentOS 7/8 Ubuntu 16/18
Issue
The
resource
stanza seems to be ignored during the first plan (i.e. before the job is submitted)Reproduction steps
Use the example job file below, notice the large amount of memory requested; there is no machine in the network with that much memory.
Running
nomad plan
should catch this and show the usual "memory exhausted ..." message.Job file (if appropriate)
Output of
nomad plan
... 😖Of course,
nomad run
makes the job go into 'Pending' state...The text was updated successfully, but these errors were encountered: