Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Scaling observability #8551

Merged
merged 15 commits into from
Jul 30, 2020
Merged

UI: Scaling observability #8551

merged 15 commits into from
Jul 30, 2020

Conversation

DingoEatingFuzz
Copy link
Contributor

This adds recent scaling events to the Task Group Detail page.

Scaling events will typically be generated by the nomad autoscaler, but they can also be generated by the UI and any api calls to POST /v1/:job/scale.

image

@DingoEatingFuzz DingoEatingFuzz added this to the 0.12.2 milestone Jul 28, 2020
@DingoEatingFuzz DingoEatingFuzz requested review from backspace and a team July 28, 2020 16:55
@github-actions
Copy link

github-actions bot commented Jul 28, 2020

Ember Asset Size action

As of 75aa9ce

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +21.3 kB +1.8 kB
nomad-ui.css +252 B +46 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Jul 28, 2020

Ember Test Audit comparison

master 75aa9ce change
passes 1347 1363 +16
failures 0 0 0
flaky 0 0 0
duration 6m 28s 793ms 7m 10s 385ms +41s 592ms

Copy link
Contributor

@backspace backspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t manage to gain access to the test autoscaling cluster, so I only tried this out in Mirage, but it looks good to me! I left some minor comments for possible improvements but nothing blocking. 🥳

@@ -1,5 +1,5 @@
{{#if this.isOpen}}
<div data-test-accordion-body class="accordion-body">
<div data-test-accordion-body class="accordion-body {{if this.fullBleed "is-full-bleed"}}">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this dedent is unintentional?

<span data-test-time title="{{format-ts a.item.time}}">{{format-month-ts a.item.time}}</span>
</span>
</div>
<div class="column is-2">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it’s overkill but I hovered over this just to see, a tooltip/title like “Scaled up/down to X” could be nice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that could be nice. The autoscaler folks are also looking into improving the messages they emit, so that should help too.

import { tagName } from '@ember-decorators/component';

@tagName('')
export default class ScaleEventsAccordion extends Component {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file can be deleted entirely thanks to Octane 🤓

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OH YEAH! So if you don't make a component js file, it defaults to a glimmer component?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya exactly 🤠

@DingoEatingFuzz DingoEatingFuzz merged commit de817be into master Jul 30, 2020
@DingoEatingFuzz DingoEatingFuzz deleted the f-ui/scaling-observability branch July 30, 2020 05:38
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants