-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Task group scaling timeline #8593
Conversation
Displays all scale events in the form of an annotated line chart. When annotations are clicked, the timestamp, message, and meta propeties for the event are displayed below the chart.
b0c64e4
to
208eb0d
Compare
Ember Asset Size actionAs of 950c2bd Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, a sensible way to build on existing things. I have a couple of questions and minor suggestions but nothing blocking.
Co-authored-by: Buck Doyle <buck@hashicorp.com>
…t short-circuit evaluation
Thank you for the feedback @backspace, I added a test for staggered annotations and made the dom elements stable. I also found a bug in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
total success! 😀
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
The continuation of #8551. Now the task group detail page will conditionally show the recent scaling events as an accordion of activity or as a timeline visualization with interactive annotations.
The timeline will be shown if there are more count events than non-count events and if there are at least two count events. This should be most of the time for most jobs.
This also includes a couple new Stories for the line chart component, including one that demonstrates annotation staggering: