UI: Task group scaling timeline #8593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Displays all scale events in the form of an annotated line chart. When annotations are clicked, the timestamp, message, and meta propeties for the event are displayed below the chart.
DingoEatingFuzz
force-pushed
the
f-ui/scaling-events-chart
branch
from
b0c64e4
to
208eb0d
Compare
Ember Asset Size actionAs of 950c2bd Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
backspace
approved these changes
Aug 6, 2020
Co-authored-by: Buck Doyle <buck@hashicorp.com>
…t short-circuit evaluation
|
Thank you for the feedback @backspace, I added a test for staggered annotations and made the dom elements stable. I also found a bug in the |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The continuation of #8551. Now the task group detail page will conditionally show the recent scaling events as an accordion of activity or as a timeline visualization with interactive annotations.
The timeline will be shown if there are more count events than non-count events and if there are at least two count events. This should be most of the time for most jobs.
This also includes a couple new Stories for the line chart component, including one that demonstrates annotation staggering: