csi: release claims via csi_hook postrun unpublish RPC #8580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
b-csi-node-drain
branch
2 times, most recently
from
ad7cbca
to
0356e51
Compare
langmartin
approved these changes
Aug 6, 2020
| WriteRequest: structs.WriteRequest{ | ||
| Region: c.alloc.Job.Region, Namespace: c.alloc.Job.Namespace}, | ||
| } | ||
| err := c.rpcClient.RPC("CSIVolume.Unpublish", |
There was a problem hiding this comment.
Summary of side discussion: retries here are optional, and at best might speed up some cases of releasing the claim. A failure here will be retried in volume GC, when the terminal (or already GC'd nil) alloc is observed in the volume & claims. So this is cool
Add a Postrun hook to send the `CSIVolume.Unpublish` RPC to the server. This may forward client RPCs to the node plugins or to the controller plugins, depending on whether other allocations on this node have claims on this volume.
By making clients responsible for running the `CSIVolume.Unpublish` RPC (and making the RPC available to a `nomad volume detach` command), the volumewatcher becomes only used by the core GC job.
tgross
force-pushed
the
b-csi-node-drain
branch
from
0356e51
to
08aaed8
Compare
This was referenced Aug 7, 2020
Closed
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a fix for #8080, #8100, #8232 as summarized in #8232 (comment). Will help mitigate #8285, #8145, #8057. (4 of 4 PRs)
Add a Postrun hook to send the
CSIVolume.UnpublishRPC to the server. Thismay forward client RPCs to the node plugins or to the controller plugins,
depending on whether other allocations on this node have claims on this
volume.