docs: always use -ignore-system on node drain with CSI #8606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postrun hooks for allocation runners don't currently block the registration of terminal health with the servers, which is what allows system jobs to be drained. So draining nodes with jobs that claim CSI volumes requires the `-ignore-system` job to ensure that the postrun hook for service jobs gets a chance to execute.
langmartin
approved these changes
Aug 7, 2020
jippi
reviewed
Aug 8, 2020
| @@ -65,8 +67,10 @@ operation is desired. | |||
| - `-no-deadline`: No deadline allows the allocations to drain off the node | |||
| without being force stopped after a certain deadline. | |||
|
|
|||
| - `-ignore-system`: Ignore system allows the drain to complete without stopping | |||
| system job allocations. By default system jobs are stopped last. | |||
| - `-ignore-system`: Ignore system allows the drain to complete without | |||
There was a problem hiding this comment.
@tgross I kinda wish this flag was default "on", I've yet had a case where I haven't had to set this to true in my various nomad deployments
There was a problem hiding this comment.
I think I agree. Let me float that by the rest of the team to see if it's something we feel safe flipping before 1.0.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postrun hooks for allocation runners don't currently block the registration of
terminal health with the servers, which is what allows system jobs to be
drained. So draining nodes with jobs that claim CSI volumes requires the
-ignore-systemjob to ensure that the postrun hook for service jobs gets achance to execute.
This docs change is associated with #8580 inasmuch as that PR can't fully solve the node drain issue summarized in #8232 (comment)