Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IP returned from CNI to register service in Consul #8698

Closed
daledude opened this issue Aug 19, 2020 · 2 comments · Fixed by #9095
Closed

Use IP returned from CNI to register service in Consul #8698

daledude opened this issue Aug 19, 2020 · 2 comments · Fixed by #9095
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/cni

Comments

@daledude
Copy link

This is a feature request unless I'm missing something.

It seems nomad does not use the IP address returned from CNI to register the task in Consul. It would be very useful to us if CNI was used to it's full intended purpose.

nomad/client/allocrunner/networking_cni.go

Line 92 in 20947a5

//TODO eventually returning the IP from the result would be nice to have in the alloc

@yishan-lin
Copy link
Contributor

We're working on this at the moment - stay tuned!

@tgross tgross added stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/cni labels Aug 24, 2020
@Tetha Tetha mentioned this issue Sep 1, 2020
Closed
@nickethier nickethier mentioned this issue Oct 15, 2020
Merged
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/cni
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consul with CNI and host_network addresses hashicorp/nomad
3 participants
@daledude @tgross @yishan-lin