-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consul with CNI and host_network addresses #9095
Conversation
Looks like a number of tests are gonna need |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* consul: advertise cni and multi host interface addresses * structs: add service/check address_mode validation * ar/groupservices: fetch networkstatus at hook runtime * ar/groupservice: nil check network status getter before calling * consul: comment network status can be nil
This looks really promising :) @tgross @schmichael I see this is slated for 1.0 - what are your thoughts on releasing a 0.12.8 with this included? Could make the upgrade path to 1.0 a lot smoother I think. |
Hi @Legogris generally speaking we don't backport features to previous versions of Nomad, only critical bugs and security patches. |
@tgross This is a bugfix, no? Given that only with this change is it possible (hopefully!) to get the mapping between services and IPs working as documented when running with Consul (this has been broken since 0.12 as brought up in several issues). I don't know how representative we are but this is a significant one here. |
@nickethier Since you've been the one mostly working on this, what's your stance on the above? Just so there's no confusion, using |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR implements a new service and check
address_mode
namedalloc
. Thealloc
service address mode signals that the address used when making Consul service and check registrations should be derived from the allocation's network namespace. This enables addresses which are created via CNI to be registered directly with Consul rather than having to expose them through Nomad's port mapping.I added some validation to error when this mode is uses with service blocks under a task.
This PR also uses the correct
host_network
address when registering in host/default mode.fixes #8801
fixes #8698