ar/groupservice: remove drivernetwork #9233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmichael
approved these changes
Oct 30, 2020
There was a problem hiding this comment.
Looks like a test broke. Maybe we can remove it and associated code? No one should be upgrading clients directly from 0.8 -> 1.0. https://app.circleci.com/pipelines/github/hashicorp/nomad/12842/workflows/41b0e3b2-d70a-4eab-9fc2-14e861417d60/jobs/114246
schmichael
reviewed
Nov 2, 2020
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #9095 where the wrong port was used in service registration. This is because group services initially passed the port to the service watcher through use of a DriverNetwork. #9095 switch to using newer apis/interfaces that weren't previously available at the time, but didn't remove this initial functionality causing the wrong port number to be used on registration.
fixes #9221