-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System jobs require restart after adding upstreams #8754
Comments
Hi @AnthonySendra that certainly doesn't look right to me. I've tagged this so the appropriate folks can dig into it. Thanks for reporting this issue! |
Hello, |
Apologies for the extremely long delay @AnthonySendra, I'm looking into this now |
…eams are modified This PR fixes a bug where modifying the upstreams of a Connect sidecar proxy would not result Consul applying the changes, unless an additional change to the job would trigger a task replacement (thus replacing the service definition). The fix is to check if upstreams have been modified between Nomad's view of the sidecar service definition, and the service definition for the sidecar that is actually registered in Consul. Fixes #8754
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Nomad version
0.12.3
Issue
When a proxy upstream is added to a job of
type = "system"
, the container is not restarted but the new configuration is not taken into account. The new upstream is unreachable from the container and we need to restart the job to make it work.When the job type is set to
service
everything works as expected: the container is not restarted and the new upstream can be reached.Reproduction steps
api1
api2
without upstreamapi2
with upstream toapi1
(uncomment the upstream part of the following job)api2
container and try to curlapi1
:curl http://127.0.0.1:7777
Job file (if appropriate)
api1
api2
The text was updated successfully, but these errors were encountered: