Fix escapingio handling of \n~\n
#8798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The escapingio reader detects new lines followed by an escaping char
\n~, but apparently if the escape char is followed by another new line, the reader ignores this read line and looks for another new line. This results into the reader not handling\n~\n~..This PR fixes the bug, by ensuring that if
\nfollows a~, we emit the text and set parser state tosLookEscapeChar.The TestEscapingReader_Static fails in the first commit in
https://app.circleci.com/pipelines/github/hashicorp/nomad/11526/workflows/c6193ea7-18a9-439c-8f93-6810845ce224/jobs/96780/tests but succeeds after applying the logic change.
Fixes #8736 .