Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] configuring resources for gateway stanza #9474

Closed
fredwangwang opened this issue Nov 30, 2020 · 3 comments · Fixed by #9639
Closed

[feature] configuring resources for gateway stanza #9474

fredwangwang opened this issue Nov 30, 2020 · 3 comments · Fixed by #9639
Labels
good first issue stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/consul/connect Consul Connect integration
Milestone
1.0.2

Comments

@fredwangwang
Copy link
Contributor

Nomad version

v0.12.5

Hi! We are trying to use the gateway stanza to streamline the process of deploying the ingress gateway. However, we noticed that there is (seems?) no easy way to configure the resources for the gateway task:

nomad/nomad/job_endpoint_hook_connect.go

Line 337 in ec7bf9d

Resources: connectSidecarResources(),
Recourse is hardcoded to use the defaults resources.

To set the resources we could manually create the whole task section to override, but curious if there is any plan to add like sidecar_task or something to simplify the resource definition for gateway task?
@shoenig shoenig added stage/accepted Confirmed, and intend to work on. No timeline committment though. good first issue theme/consul/connect Consul Connect integration labels Dec 2, 2020
@shoenig
Copy link
Member

shoenig commented Dec 2, 2020

Thanks for reporting, @fredwangwang - indeed our gateway support is still pretty MVP and isn't yet configurable in the same way connect sidecar proxies are. Improving this story is on our near term road map.

@hammad13060
Copy link

@shoenig I'd like to work on this. Can you assign this issue to me? Thanks.

@shoenig shoenig mentioned this issue Dec 11, 2020
Closed
shoenig added a commit that referenced this issue Dec 15, 2020
@shoenig
consul/connect: enable configuring custom gateway task
dd6bca0 
Add the ability to configure the Task used for Connect gateways,
similar to how sidecar Task can be configured.

The implementation here simply re-uses the sidecar_task stanza,
and now gets applied whether connect.sidecar_service or
connect.gateway is the thing being defined. In retrospect,
connect.sidecar_task could have been more generically named
like connect.task to make it a little more re-usable.

Closes #9474
@shoenig shoenig mentioned this issue Dec 15, 2020
Merged
shoenig added a commit that referenced this issue Dec 17, 2020
@shoenig
consul/connect: enable configuring custom gateway task
81d82dc 
Add the ability to configure the Task used for Connect gateways,
similar to how sidecar Task can be configured.

The implementation here simply re-uses the sidecar_task stanza,
and now gets applied whether connect.sidecar_service or
connect.gateway is the thing being defined. In retrospect,
connect.sidecar_task could have been more generically named
like connect.task to make it a little more re-usable.

Closes #9474
@shoenig shoenig added this to the 1.0.2 milestone Dec 17, 2020
backspace pushed a commit that referenced this issue Jan 22, 2021
@shoenig @backspace
consul/connect: enable configuring custom gateway task
02d41cc 
Add the ability to configure the Task used for Connect gateways,
similar to how sidecar Task can be configured.

The implementation here simply re-uses the sidecar_task stanza,
and now gets applied whether connect.sidecar_service or
connect.gateway is the thing being defined. In retrospect,
connect.sidecar_task could have been more generically named
like connect.task to make it a little more re-usable.

Closes #9474
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/consul/connect Consul Connect integration
Projects
None yet
Milestone
1.0.2
Development

Successfully merging a pull request may close this issue.

consul/connect: enable configuring custom gateway task hashicorp/nomad
3 participants
@shoenig @fredwangwang @hammad13060