-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] configuring resources for gateway stanza #9474
Comments
Thanks for reporting, @fredwangwang - indeed our gateway support is still pretty MVP and isn't yet configurable in the same way connect sidecar proxies are. Improving this story is on our near term road map. |
@shoenig I'd like to work on this. Can you assign this issue to me? Thanks. |
Add the ability to configure the Task used for Connect gateways, similar to how sidecar Task can be configured. The implementation here simply re-uses the sidecar_task stanza, and now gets applied whether connect.sidecar_service or connect.gateway is the thing being defined. In retrospect, connect.sidecar_task could have been more generically named like connect.task to make it a little more re-usable. Closes #9474
Add the ability to configure the Task used for Connect gateways, similar to how sidecar Task can be configured. The implementation here simply re-uses the sidecar_task stanza, and now gets applied whether connect.sidecar_service or connect.gateway is the thing being defined. In retrospect, connect.sidecar_task could have been more generically named like connect.task to make it a little more re-usable. Closes #9474
Add the ability to configure the Task used for Connect gateways, similar to how sidecar Task can be configured. The implementation here simply re-uses the sidecar_task stanza, and now gets applied whether connect.sidecar_service or connect.gateway is the thing being defined. In retrospect, connect.sidecar_task could have been more generically named like connect.task to make it a little more re-usable. Closes #9474
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Nomad version
v0.12.5
Hi! We are trying to use the gateway stanza to streamline the process of deploying the ingress gateway. However, we noticed that there is (seems?) no easy way to configure the resources for the gateway task:
nomad/nomad/job_endpoint_hook_connect.go
Line 337 in ec7bf9d
To set the resources we could manually create the whole task section to override, but curious if there is any plan to add like
sidecar_task
or something to simplify the resource definition for gateway task?The text was updated successfully, but these errors were encountered: