-var-file argument has no effect

[cpcloud]

Nomad version

Output from nomad version

❯ nomad version
Nomad v1.0.0

Operating system and Environment details

OS: NixOS

Issue

The -var-file argument appears to have no effect when running jobs.

After digging around in the code, it looks like the code called by nomad job run here

nomad/command/job_run.go

Line 197 in 8a66f11

job, err := c.JobGetter.ApiJobWithArgs(args[0], varArgs, varFiles)

passes varFiles in here

nomad/command/helpers.go

Line 394 in 86882df

func (j *JobGetter) ApiJobWithArgs(jpath string, vars []string, varfiles []string) (*api.Job, error) {

, but the varfiles variable is never used in the body of ApiJobWithArgs so the variables never get interpolated in.

Reproduction steps

Make a file with a command variable defined, this can be any string but I set it to a valid executable path.

❯ cat test.vars
command = "/run/current-system/sw/bin/ls"

Run the job file below:

❯ nomad job run -var-file="./test.vars" ./test.nomad
Error getting job struct: Error parsing job file from ./test.nomad:
<nil>: Unset variable "command"; A used variable must be set or have a default value; see https://packer.io/docs/configuration/from-1.5/syntax for details.

Job file (if appropriate)

variable "command" {
  type = string
}

job "test" {
  group "test" {
    task "test" {
      driver = "raw_exec"
      config {
        command = "${var.command}"
      }
    }
  }
}

[cpcloud]

Looks like it just needs to be passed in, according to this test

nomad/jobspec2/parse_test.go

Line 155 in b67d9ec

VarFiles: []string{varFile.Name()},

[notnoop]

Thanks for reporting the bug! That's embarrassing 🤦 . We'll follow up with a fix soon.

[notnoop]

Thanks @cpcloud again. I have merged the fix, and it should be out in 1.0.1!

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.