Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actually honor var files #9592

Merged
merged 1 commit into from
Dec 9, 2020
Merged

actually honor var files #9592

merged 1 commit into from
Dec 9, 2020

Conversation

notnoop
Copy link
Contributor

@notnoop notnoop commented Dec 9, 2020

Apparently, we missed passing VarFile argument, so var files were
ignored.

Fixes #9588

Apparently, we missed passing VarFile argument, so var files were
ignored.
@notnoop notnoop requested a review from shoenig December 9, 2020 18:30
@notnoop notnoop self-assigned this Dec 9, 2020
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@notnoop notnoop merged commit 6bfbadc into master Dec 9, 2020
@notnoop notnoop deleted the b-honor-var-file-input branch December 9, 2020 19:12
schmichael pushed a commit that referenced this pull request Dec 16, 2020
Apparently, we missed passing VarFile argument, so var files were
ignored.

Fixes #9588
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-var-file argument has no effect
2 participants