Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scan compressed module names in modules.dep #9776

Closed
shoenig opened this issue Jan 12, 2021 · 2 comments
Closed

Scan compressed module names in modules.dep #9776

shoenig opened this issue Jan 12, 2021 · 2 comments
Labels
theme/networking type/bug

Comments

@shoenig
Copy link
Member

shoenig commented Jan 12, 2021

#9299 (comment)

Looks like CentOS boxes lists compressed module names in modules.dep, which are missed by the current regexp.

@apollo13

would it be possible to include (.xz)? in the regex in https://github.com/hashicorp/nomad/pull/9299/files#diff-25979a0adb76fadc59ae57997b3d3e70ac415168d760bd3e6d95b8db1cca7cc6R19 ?
@shoenig shoenig added this to Needs Triage in Nomad - Community Issues Triage via automation Jan 12, 2021
@shoenig shoenig mentioned this issue Jan 12, 2021
Merged
@shoenig shoenig moved this from Needs Triage to Triaged in Nomad - Community Issues Triage Jan 12, 2021
@apollo13
Copy link
Contributor

Ok, #9779 for your reviewing pleasure. Let's see if the tests work out well :)

shoenig added a commit that referenced this issue Jan 12, 2021
@shoenig
Merge pull request #9779 from apollo13/fix_9776
70b5302 
Properly detect unloaded dynamic modules on RHEL derivates. Fixes #9776
Nomad - Community Issues Triage automation moved this from Triaged to Done Jan 12, 2021
backspace pushed a commit that referenced this issue Jan 22, 2021
@apollo13 @backspace
Properly detect unloaded dynamic modules on RHEL derivates. Fixes #9776
58f4f73 
The modules.dep file on RHEL includes .xz for compressed kernel modules.
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
theme/networking type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apollo13 @shoenig