Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to fail deployment from the UI #9826

Closed
urusha opened this issue Jan 15, 2021 · 3 comments
Closed

Ability to fail deployment from the UI #9826

urusha opened this issue Jan 15, 2021 · 3 comments
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/ui type/enhancement

Comments

@urusha
Copy link

urusha commented Jan 15, 2021

It would be great if we could forcibly fail running deployment from the UI, just like nomad deployment fail ID.
backspace added a commit that referenced this issue Jan 15, 2021
@backspace
Add button to fail running deployments
61cca85 
As suggested in #9826. The placement is currently ridiculous.
@backspace backspace mentioned this issue Jan 15, 2021
Merged
@tgross tgross added theme/ui stage/accepted Confirmed, and intend to work on. No timeline committment though. type/enhancement labels Jan 15, 2021
backspace added a commit that referenced this issue Feb 10, 2021
@backspace
Add button to fail running deployments (#9831)
d98265d 
This closes #8744 and #9826.

It necessitated some customisation options for TwoStepButton. One is inlineText, which puts the confirmation text in the same line as the buttons. Also, there was a single-use configuration option named isInfoAction that I removed in favour of passing a set of class configuration options like this:

                @classes={{hash
                  idleButton="is-warning"
                  confirmationMessage="inherit-color"
                  cancelButton="is-danger is-important"
                  confirmButton="is-warning"}}
@tgross
Copy link
Member

tgross commented Feb 12, 2021

@backspace it looks like #9831 was merged. Can we close this?

@tgross tgross added this to Needs Roadmapping in Nomad - Community Issues Triage Feb 12, 2021
@backspace
Copy link
Contributor

hmm yes, I meant to include the magic closes phrase but I failed to I guess! Thanks.

Nomad - Community Issues Triage automation moved this from Needs Roadmapping to Done Feb 16, 2021
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/ui type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@backspace @tgross @urusha