-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSS Nomad spam Enterprise-only related errors in logs #9827
Comments
Hi @Oloremo thanks for reporting, This seems to be caused by the UI checking for enterprise functionality. Unfortunately it looks like it checks or tried to fetch license info on every request. We'll take a look and discuss how to improve this. |
hmm, I believe the UI only attempts to load the license once, when the application initialises. Unfortunately, as the API is currently set up, there’s no way for the UI to know whether it’s communicating with enterprise vs OSS without this query. One possible avenue of improvement would be to add an endpoint that doesn’t return an error code when it’s OSS, or adjusting this one to have a defined non-error response that represents OSS. |
Sorry @backspace, "on every request" I meant I was seeing it each time I loaded http://localhost:4646/ui/jobs. I like your suggested approach, the API should be able to provide a better response. |
If you haven’t already done anything to this effect, @drewbailey, I could dabble in a little Go to hopefully make this happen 😯 |
@backspace I haven't had the chance to dig in yet, happy to help out if you decide to dabble 😁 |
Will do, I have a few things I should wrap up before starting something new, but I’ll let you know 😀 |
This changes the license-fetching endpoint to respond with 204 in OSS instead of 501. It closes #9827.
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Nomad version
Nomad v1.0.2 (4c1d4fc6a5823ebc8c3e748daec7b4fda3f11037)
Operating system and Environment details
Centos 7.6 x64
Issue
Nomad logs are spammed by:
We use OSS version so not sure why it does it.
Maybe related to the fact that we have telemetry enabled?
Reproduction steps
Kinda related to #4567
The text was updated successfully, but these errors were encountered: