Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSS Nomad spam Enterprise-only related errors in logs #9827

Closed
Oloremo opened this issue Jan 15, 2021 · 7 comments · Fixed by #9963
Closed

OSS Nomad spam Enterprise-only related errors in logs #9827

Oloremo opened this issue Jan 15, 2021 · 7 comments · Fixed by #9963
Labels
stage/needs-discussion theme/api HTTP API and SDK issues theme/bad-ux theme/enterprise Issues related to Enterprise features theme/ui

Comments

@Oloremo
Copy link
Contributor

Oloremo commented Jan 15, 2021

Nomad version

Nomad v1.0.2 (4c1d4fc6a5823ebc8c3e748daec7b4fda3f11037)

Operating system and Environment details

Centos 7.6 x64

Issue

Nomad logs are spammed by:

2021-01-15T14:52:09.436Z [ERROR] http: request failed: method=GET path=/v1/operator/license error="Nomad Enterprise only endpoint" code=501

We use OSS version so not sure why it does it.

Maybe related to the fact that we have telemetry enabled?

Reproduction steps

  1. Run OSS version
  2. Wait

Kinda related to #4567

@drewbailey drewbailey added theme/bad-ux stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/enterprise Issues related to Enterprise features theme/ui stage/needs-discussion and removed stage/accepted Confirmed, and intend to work on. No timeline committment though. labels Jan 15, 2021
@drewbailey
Copy link
Contributor

Hi @Oloremo thanks for reporting, This seems to be caused by the UI checking for enterprise functionality. Unfortunately it looks like it checks or tried to fetch license info on every request. We'll take a look and discuss how to improve this.

@backspace
Copy link
Contributor

hmm, I believe the UI only attempts to load the license once, when the application initialises.

Unfortunately, as the API is currently set up, there’s no way for the UI to know whether it’s communicating with enterprise vs OSS without this query. One possible avenue of improvement would be to add an endpoint that doesn’t return an error code when it’s OSS, or adjusting this one to have a defined non-error response that represents OSS. 204 No Content?

@drewbailey
Copy link
Contributor

Sorry @backspace, "on every request" I meant I was seeing it each time I loaded http://localhost:4646/ui/jobs. I like your suggested approach, the API should be able to provide a better response.

@drewbailey drewbailey added the theme/api HTTP API and SDK issues label Jan 15, 2021
@backspace
Copy link
Contributor

If you haven’t already done anything to this effect, @drewbailey, I could dabble in a little Go to hopefully make this happen 😯

@drewbailey
Copy link
Contributor

@backspace I haven't had the chance to dig in yet, happy to help out if you decide to dabble 😁

@backspace
Copy link
Contributor

backspace commented Jan 21, 2021

Will do, I have a few things I should wrap up before starting something new, but I’ll let you know 😀

backspace added a commit that referenced this issue Feb 8, 2021
This changes the license-fetching endpoint to respond with 204 in
OSS instead of 501. It closes #9827.
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stage/needs-discussion theme/api HTTP API and SDK issues theme/bad-ux theme/enterprise Issues related to Enterprise features theme/ui
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants