Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix deployment failure error handling #10003

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

backspace
Copy link
Contributor

This is a supplement to #9831 to incorporate the extracted
missing-permissions error handling from #9909.

It fixes this failure on the main branch! 😳

This is a supplement to #9831 to incorporate the extracted
missing-permissions error handling from #9909.
@github-actions
Copy link

Ember Asset Size action

As of 7863650

Files that got Smaller 🎉:

File raw gzip
nomad-ui.js -86 B -75 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

Ember Test Audit comparison

master 7863650 change
passes 1553 1555 +2
failures 2 0 -2
flaky 0 0 0
duration 000ms 8m 55s 551ms +8m 55s 551ms

Copy link
Contributor

@DingoEatingFuzz DingoEatingFuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew, thank you tests!

@backspace backspace merged commit 1d0c57d into master Feb 10, 2021
@backspace backspace deleted the b-ui/deployment-fail-forbiddenerror branch February 10, 2021 16:23
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants