Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deploymentwatcher: reset progress deadline on promotion #10042

Merged
merged 4 commits into from
Feb 22, 2021
Merged

deploymentwatcher: reset progress deadline on promotion #10042

merged 4 commits into from
Feb 22, 2021

Commits on Feb 22, 2021

  1. deployments: comment clarifications and more logging

    @tgross
    tgross committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    d77dc01 View commit details
    Browse the repository at this point in the history

  2. deploymentwatcher: failing test 

    Test demonstrating a bug with canary deployments when there are multiple
groups. If group A's canary becomes healthy before group B's, the deadline
for the overall deployment will be set to that of group A. When the deployment
is promoted, if group A is done it will not contribute to the next deadline
cutoff. Group B's old deadline will be used instead, which will be in the past
and immediately trigger a deployment progress failure.
    @tgross
    tgross committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    ce97bc3 View commit details
    Browse the repository at this point in the history

  3. deploymentwatcher: reset progress deadline on promotion

    @tgross
    tgross committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    a4544bf View commit details
    Browse the repository at this point in the history

  4. docs updates and changelog entry

    @tgross
    tgross committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    80e28a5 View commit details
    Browse the repository at this point in the history