Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Fix rendering of DAS interstitial components #10094

Merged
merged 2 commits into from
Mar 1, 2021
Merged

UI: Fix rendering of DAS interstitial components #10094

merged 2 commits into from
Mar 1, 2021

Commits on Feb 26, 2021

  1. Fix rendering of DAS interstitial components 

    With the Ember update, when the will-destroy action is called
to check the element height, its height is already zero. That
seems strange but I didn’t look into it any further, as
using did-insert to store the element lets us check its height
before any other actions when a processing button is pressed.
    @backspace
    backspace committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    2263d71 View commit details
    Browse the repository at this point in the history

  2. Add changelog entry

    @backspace
    backspace committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    8e1bc91 View commit details
    Browse the repository at this point in the history