-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug: update defaults to commonly used values #10121
Conversation
CHANGELOG.md
Outdated
@@ -4,6 +4,7 @@ BUG FIXES: | |||
* api: Added missing devices block to AllocatedTaskResources [[GH-10064](https://github.com/hashicorp/nomad/pull/10064)] | |||
* cli: Fixed a bug where non-int proxy port would panic CLI [[GH-10072](https://github.com/hashicorp/nomad/issues/10072)] | |||
* cli: Fixed a bug where `nomad operator debug` incorrectly parsed https Consul API URLs. [[GH-10082](https://github.com/hashicorp/nomad/pull/10082)] | |||
* cli: Update defaults for `nomad operator debug` flags `-interval` and `-server-id` to match common usage. [GH-10121] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make changelogfmt
will take this tag and automatically do the right thing for the URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not quite, this should now be reading [[GH-10121](https://github.com/hashicorp/nomad/pull/10121)]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what happened during the rebase to main, but this is back in place now.
Update tests to reflect interval validation
e80df2f
to
0f0e9a0
Compare
@tgross CircleCI finished testing the rebase to main, so I think we're good to go here. Can you give it a once-over for approval? |
Co-authored-by: Tim Gross <tgross@hashicorp.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR updates the following default values in
nomad operator debug
to match the most commonly requested settings:-interval=30s
instead of 2m-server-id=all
instead of noneIt also adds
nomad-debug-*
to .gitignore for better usability during development.