Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler/csi: fix early return when multiple volumes are requested #10143

Merged
merged 1 commit into from
Mar 10, 2021

Commits on Mar 9, 2021

  1. scheduler/csi: fix early return when multiple volumes are requested

    When multiple CSI volumes are requested, the feasibility check could return
    early for read/write volumes with free claims, even if a later volume in the
    request was not feasible for any other reason (including not existing at
    all). This can result in random failure to fail feasibility checking,
    depending on how the map of volumes was being ordered at runtime.
    
    Remove the early return from the feasibility check. Add a test to verify that
    missing volumes in the map will cause a failure; this test will not catch a
    regression every test run because of the random map ordering, but any failure
    will be caught over the course of several CI runs.
    tgross committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    91f8126 View commit details
    Browse the repository at this point in the history