Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI: remove prefix matching from CSIVolumeByID and fix CLI prefix matching #10158

Merged
merged 3 commits into from
Mar 18, 2021
Merged

CSI: remove prefix matching from CSIVolumeByID and fix CLI prefix matching #10158

merged 3 commits into from
Mar 18, 2021

Commits on Mar 10, 2021

  1. csi: CSIVolumeByID should not use prefix query 

    Callers of `CSIVolumeByID` are generally assuming they should receive a single
volume. This potentially results in feasibility checking being performed
against the wrong volume if a volume's ID is a prefix substring of other
volume (for example: "test" and "testing").
    @tgross
    tgross committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    97bb912 View commit details
    Browse the repository at this point in the history

  2. csi: reimplement prefix matching 

    Removing the incorrect prefix matching from `CSIVolumeByID` breaks prefix
matching in the command line client. Add the required elements for prefix
matching to the commands and API.
    @tgross
    tgross committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    25782f3 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. resolve comments from code review

    @tgross
    tgross committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    5836f3b View commit details
    Browse the repository at this point in the history