Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated Drain field from structs.Node #10202

Merged
merged 16 commits into from
Apr 1, 2021
Merged

remove deprecated Drain field from structs.Node #10202

merged 16 commits into from
Apr 1, 2021

Commits on Mar 21, 2021

  1. removed deprecated fields from Drain structs and API 

    node drain: use msgtype on txn so that events are emitted
wip: encoding extension to add Node.Drain field back to API responses

new approach for hiding Node.SecretID in the API, using `json` tag
documented this approach in the contributing guide
refactored the JSON handlers with extensions
modified event stream encoding to use the go-msgpack encoders with the extensions
    @cgbaker
    cgbaker committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    93d5187 View commit details
    Browse the repository at this point in the history

  2. updated node drain API test

    @cgbaker
    cgbaker committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    574d26c View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2021

  1. refactor?

    @cgbaker
    cgbaker committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    ca51bd9 View commit details
    Browse the repository at this point in the history

  2. moved JSON handlers and extension code around a bit for proper order of 

    initialization
    @cgbaker
    cgbaker committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    0cd707e View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2021

  1. added tests that the API doesn't leak Node.SecretID 

    added more documentation on JSON encoding to the contributing guide
    @cgbaker
    cgbaker committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    7d78ffb View commit details
    Browse the repository at this point in the history

  2. change to fail-safe in json encoding

    @cgbaker
    cgbaker committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    bc90436 View commit details
    Browse the repository at this point in the history

  3. some comments on the new json extensions/encoding

    @cgbaker
    cgbaker committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    6043594 View commit details
    Browse the repository at this point in the history

  4. added benchmark test for JSON encoding extensions

    @cgbaker
    cgbaker committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    23c75b0 View commit details
    Browse the repository at this point in the history

  5. t push 

    changelog for #10202
    @cgbaker
    cgbaker committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    e0b5320 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2021

  1. additional consistency checking on nodes api

    @cgbaker
    cgbaker committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    4e7d84e View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2021

  1. squash

    @cgbaker
    cgbaker committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    c5731eb View commit details
    Browse the repository at this point in the history

  2. restored Node.Sanitize() for RPC endpoints 

    multiple other updates from code review
    @cgbaker
    cgbaker committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    a52f32d View commit details
    Browse the repository at this point in the history

  3. reinserted/expanded fsm node.canonicalize test that was still needed

    @cgbaker
    cgbaker committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    405efe6 View commit details
    Browse the repository at this point in the history

  4. Update contributing/checklist-jobspec.md

    @cgbaker
    cgbaker committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    e9c552b View commit details
    Browse the repository at this point in the history

  5. reworked Node.Canonicalize() to enforce invariants, fixed a broken test

    @cgbaker
    cgbaker committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    ed636ad View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2021

  1. Merge branch 'main' into f-node-drain-api

    @cgbaker
    cgbaker committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    80066ac View commit details
    Browse the repository at this point in the history