Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Showed host reservations and allocation utilization by task on existing stats charts #10208

Merged
merged 24 commits into from
Mar 25, 2021
Merged

UI: Showed host reservations and allocation utilization by task on existing stats charts #10208

merged 24 commits into from
Mar 25, 2021

Commits on Mar 24, 2021

  1. Pass the LineChart named blocks through to callers of StatsTimeSeries

    @DingoEatingFuzz
    DingoEatingFuzz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    febecbb View commit details
    Browse the repository at this point in the history

  2. Compute and render reserved annotations for client stats

    @DingoEatingFuzz
    DingoEatingFuzz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    ce7f6d0 View commit details
    Browse the repository at this point in the history

  3. Refactor PrimaryMetric into parts/purposes 

    Currently, PrimaryMetric is already overloaded on multiple dimensions:
metric and resource type.

This refactor will use multiple components as a form of control flow
instead spidering conditionals, which are only getting worse as the
charts for each resource type diverge.
    @DingoEatingFuzz
    DingoEatingFuzz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    d6b72c1 View commit details
    Browse the repository at this point in the history

  4. Simple bind helper 

    This binds a function to a target before passing it along to another
component. It's normal to expect to get to use `this` within functions
on components and controllers, but (sans actions) that doesn't happen
automatically.
    @DingoEatingFuzz
    DingoEatingFuzz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    a6a9df5 View commit details
    Browse the repository at this point in the history

  5. Stacked percentages of tasks for alloc charts 

    This leverages the existing pre-processing being done in the
allocation-stats-tracker to also create additive percentages relative to
the allocation resources vs. the task resources.

This can then be used in a chart to create a stacked area representation
of consumption.
    @DingoEatingFuzz
    DingoEatingFuzz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    8ae7645 View commit details
    Browse the repository at this point in the history

  6. Sort and index multi-series data correctly in line chart 

     - Sorting must be done on copies to preserve orders.
 - Indices should be reversed since rendering is also reversed (the back
   layer (the tallest) is rendered first to create the stacking effect).
    @DingoEatingFuzz
    DingoEatingFuzz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    8ab3014 View commit details
    Browse the repository at this point in the history

  7. Refactor stats-time-series to allow for multiple series

    @DingoEatingFuzz
    DingoEatingFuzz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    d72eaa1 View commit details
    Browse the repository at this point in the history

  8. Refactored multi-series allocation variant of the primary metric comp… 

    …onent
    @DingoEatingFuzz
    DingoEatingFuzz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    4f27bee View commit details
    Browse the repository at this point in the history

  9. Memoize the tracker and the series properties to avoid repeat computa… 

    …tion

In addition to this computation being wasteful, it introduces a bug
where the allocation on a stats tracker can update twice in one render,
which isn't allowed in Glimmer (ironically, Glimmmer's lack of
auto-memoization introduced the issue).
    @DingoEatingFuzz
    DingoEatingFuzz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    df11688 View commit details
    Browse the repository at this point in the history

  10. Apply the new multi-line primary metric to the alloc index page

    @DingoEatingFuzz
    DingoEatingFuzz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    745a55b View commit details
    Browse the repository at this point in the history

  11. New PrimaryMetric::Task component

    @DingoEatingFuzz
    DingoEatingFuzz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    7b73460 View commit details
    Browse the repository at this point in the history

  12. Improved language around what the client stat charts represent

    @DingoEatingFuzz
    DingoEatingFuzz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    17cf4ad View commit details
    Browse the repository at this point in the history

  13. Remove now unused chartClass arg from LineChart

    @DingoEatingFuzz
    DingoEatingFuzz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    2953542 View commit details
    Browse the repository at this point in the history

  14. Tests for PrimaryMetric::Node

    @DingoEatingFuzz
    DingoEatingFuzz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    2ed5b28 View commit details
    Browse the repository at this point in the history

  15. Tests for PrimaryMetric::Allocation

    @DingoEatingFuzz
    DingoEatingFuzz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    e3a1106 View commit details
    Browse the repository at this point in the history

  16. Tests for PrimaryMetric::Task

    @DingoEatingFuzz
    DingoEatingFuzz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    ead08e2 View commit details
    Browse the repository at this point in the history

  17. Updated old tests

    @DingoEatingFuzz
    DingoEatingFuzz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    91521d6 View commit details
    Browse the repository at this point in the history

  18. Update topology info box primary metric

    @DingoEatingFuzz
    DingoEatingFuzz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    5191693 View commit details
    Browse the repository at this point in the history

  19. Remove old primary metric

    @DingoEatingFuzz
    DingoEatingFuzz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    b009fc1 View commit details
    Browse the repository at this point in the history

  20. Use more explicit branching of reserved amounts based on metric type

    @DingoEatingFuzz
    DingoEatingFuzz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    2b1449c View commit details
    Browse the repository at this point in the history

  21. Fix line-wrapping issue with chart tooltips

    @DingoEatingFuzz
    DingoEatingFuzz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    ebd91a9 View commit details
    Browse the repository at this point in the history

  22. Guard against empty data when determining active linechart data

    @DingoEatingFuzz
    DingoEatingFuzz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    1d8bc39 View commit details
    Browse the repository at this point in the history

  23. Correctly sort tasks in alloc stat tracker so the main task takes pre… 

    …cedence
    @DingoEatingFuzz
    DingoEatingFuzz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    d9426df View commit details
    Browse the repository at this point in the history

  24. Remove errant log line

    @DingoEatingFuzz
    DingoEatingFuzz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    c15bf65 View commit details
    Browse the repository at this point in the history