Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changelog: add section for backports from 1.1.0 to 1.0.5 #10267

Merged
merged 1 commit into from
Mar 30, 2021
Merged

changelog: add section for backports from 1.1.0 to 1.0.5 #10267

merged 1 commit into from
Mar 30, 2021

Conversation

tgross
Copy link
Member

@tgross tgross commented Mar 30, 2021

@tgross tgross added this to the 1.1.0 milestone Mar 30, 2021
drewbailey
drewbailey reviewed Mar 30, 2021
View reviewed changes
CHANGELOG.md Outdated
* scheduler: Fixed a bug where jobs requesting multiple CSI volumes could be incorrectly scheduled if only one of the volumes passed feasibility checking. [[GH-10143](https://github.com/hashicorp/nomad/issues/10143)]
* ui: Fixed the rendering of interstitial components shown after processing a dynamic application sizing recommendation. [[GH-10094](https://github.com/hashicorp/nomad/pull/10094)]

IMPROVEMENTS:
* api: Removed unimplemented `CSIVolumes.PluginList` API. [[GH-10158](https://github.com/hashicorp/nomad/issues/10158)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is outside the scope of your PR but I just realized we deviated from the usual order of Features -> Improvements -> Bug Fixes for 1.1.0.

I can do so in a follow up pr

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We sure did. I'll fix it while I'm in here.

drewbailey
drewbailey approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@drewbailey drewbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tgross
changelog: add section for backports from 1.1.0 to 1.0.5
5cc5d80 
* Fixed order
* Added missing changlog entry for GH-10145
* Fixed misclassified entry for GH-10158
@vercel vercel bot temporarily deployed to Preview – nomad March 30, 2021 19:45 Inactive
@tgross tgross merged commit f1645dd into main Mar 30, 2021
@tgross tgross deleted the docs-backport-changelog branch March 30, 2021 19:53
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@drewbailey drewbailey drewbailey approved these changes

@notnoop notnoop Awaiting requested review from notnoop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tgross @drewbailey