CSI: listing from plugins can return EOF #10331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoenig
reviewed
Apr 8, 2021
shoenig
approved these changes
Apr 8, 2021
The AWS EBS CSI plugin was observed to return a EOF when we get to the end of the paging for `ListSnapshots`, counter to specification. Handle this case gracefully, including for `ListVolumes` (which EBS doesn't support but has similar semantics). Also fixes a timestamp formatting bug on `ListSnapshots`
tgross
force-pushed
the
b-csi-snapshot-eof
branch
from
b3ebcbe
to
ca98716
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS EBS CSI plugin was observed (see #10322) to return a EOF when we get to the end of the paging for
ListSnapshots, counter to specification. Handle this case gracefully, including forListVolumes(which EBS doesn't support but has similar semantics).Also fixes a timestamp formatting bug on
ListSnapshots