Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate all allocs when draining a node #10411

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Migrate all allocs when draining a node #10411

merged 2 commits into from
Apr 21, 2021

Commits on Apr 20, 2021

  1. add a failing test

    Mahmood Ali committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    050ace0 View commit details
    Browse the repository at this point in the history

  2. Migrate all allocs when draining a node 

    This fixes a bug affecting drain nodes, where allocs may fail to be
migrated if they belong to different namespaces but share the same job
name.

The reason is that the helper function that creates the migration evals
indexed the allocs by job ID without accounting for the namespaces.
When job ids clash, only an eval is created for one and the rest of the
allocs remain unmigrated.
    Mahmood Ali committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    f9a4655 View commit details
    Browse the repository at this point in the history