ui: Add optional memory max to task details ribbon #10459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first step in #10268.
Ember Asset Size actionAs of a9d3964 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
DingoEatingFuzz
requested changes
Apr 28, 2021
Co-authored-by: Michael Lange <dingoeatingfuzz@gmail.com>
Co-authored-by: Michael Lange <dingoeatingfuzz@gmail.com>
|
Thanks for catching that oversight 😳💞 |
…d into f-ui/memory-max-in-ribbon
The previous implementation could show a maximum that was lower than the memory total, which could be confusing. This changes the calculation so if no maximum is specified, the sum falls back to using the memory, so the maximum shown will always be the larger number.
backspace
added a commit
that referenced
this pull request
May 18, 2021
This is a reversion from #10459, more background here: #10268 (comment)
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in #10268.