Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Handle nil MemoryMaxMB #10620

Merged
merged 3 commits into from
May 19, 2021
Merged

cli: Handle nil MemoryMaxMB #10620

merged 3 commits into from
May 19, 2021

Conversation

notnoop
Copy link
Contributor

@notnoop notnoop commented May 18, 2021

Handle when MemoryMaxMB is nil, as expected when a new 1.1.0 is hitting a pre-1.1.0 Server.

With this change, we sill still display Memory Max Usage column, though it's not meaningful:

$ nomad namespace status default
Name        = default
Description = Default shared namespace
Quota       = default-quota

Quota Limits
Region  CPU Usage   Memory Usage  Memory Max Usage  Network Usage
global  500 / 2500  256 / 1000    0 / -             - / inf

Fixes #10619

Handle when MemoryMaxMB is nil, as expected when a new 1.1.0 is hitting
a pre-1.1.0 Server.
@notnoop notnoop requested a review from tgross May 18, 2021 20:23
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I just took a quick search through the other commands that access MemoryMax and it looks like we cover ourselves for the nil case there already.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI panic in namespace status w/ quotas
2 participants